Conversation
This will produce a CSV-format summary of sections, scenarios, and tags. This provides an overview of tags applied, showing the tests which are (currently). This includes extensive testing to get Gherkinize test coverage to 100% This doesn't use red "X" and green Check because those would be limited to the `@wip` tag only.
4 tasks
kapilt
approved these changes
Jul 15, 2026
kapilt
left a comment
kapilt
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, walked through the diff, but not super familiar with gherkin, so rubber stamp, but everything looks fine to me.
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will produce a CSV-format summary of sections, scenarios, and tags. This provides an overview of tags applied, showing the tests which are currently bypassed because they're unlikely to pass. The relevant changes are lines 1072 to the end of
gherkinize.py.This doesn't exactly fit the original issue: it doesn't use ❌ and ✅. Those would be limited to the
@wiptag only, and really, other bulk tagging might be applied to the@conformancesubset of test cases.This change also includes extensive testing to get
gherkinize.pytest coverage to 100%. This means a huge change totests/test_gherkinize.pyand pervasive small changes togherkinize.pyof two kinds:Fix numerous
__eq__()methods to be more consistent in their type checking and use ofreturn NotImplemented.Fix the
Exceptioninstances to beTypeErrorwhich is a bit more specific to the problems encountered. A few might beValueError, but the nuanced distinctions rarely matter; they're very unlikely to arise from parsing source protobuf documents.Also, there are tiny cleanups applied in other places:
pyproject.toml,refresh_spec.py,test_evaluation.py, andREADME.rst.This is required to close issue #182 and issue #172. Doing this lets us create and prioritize subtasks for issue #64, which is the distant goal.