fix(gui): typing-only IDE autocomplete + ScrollPanelElement constructor#144
Open
I-No-oNe wants to merge 4 commits into
Open
fix(gui): typing-only IDE autocomplete + ScrollPanelElement constructor#144I-No-oNe wants to merge 4 commits into
I-No-oNe wants to merge 4 commits into
Conversation
The IDE surfaced autocomplete on any text-field state change, so copying, pasting, navigating and clicking would pop the suggestion box and let it hijack TAB/ENTER/UP/DOWN. TextFieldElement now reports whether a change came from typing: character entry, backspace and delete flag it as typed, while copy/cut/paste/select, caret navigation and mouse clicks do not. The IDE only updates suggestions on typed changes and hides them otherwise. (cherry picked from commit 6365aea)
…ructor verticalStack(gap) is no longer a public chained setter; the gap is now passed to a dedicated constructor and applied at construction. Updates the ModuleEditElement, ModuleEditScreen, AdvancedSettingScreen and KeybindScreen call sites to the new constructor.
…ode-only settings - move team-detection logic (isTeammate/shouldCancelCcsAttack/team checks) out of EntityUtils into TeamDetector so the util no longer imports a module; repoint ccs macro callers accordingly - TeamDetector: cache the parsed manual name list, ignore blank entries, exclude self, simplify shouldCancelCcsAttack - NoResPack: spoof the accept/download/loaded handshake after blocking a pack so servers stop hanging/kicking on forced packs - EntityIndicator: only show sprite-size in COMPASS render mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
IDE/GUI and module fixes, branched off current
main(post26.2 port part 1).1. ClickScript IDE autocomplete is now typing-only.
Previously the suggestion box was driven by any text-field state change, so
copying, pasting, caret navigation and mouse clicks would pop it up and let it
hijack
TAB/ENTER/UP/DOWN.TextFieldElementnow reports whether a changecame from typing (character entry, backspace, delete) versus not (copy/cut/paste,
select, navigation, mouse click); the IDE only refreshes suggestions on typed
changes and hides them otherwise.
2. ScrollPanelElement vertical stacking folded into a constructor.
verticalStack(gap)is no longer a public chained setter — the gap is passed to adedicated constructor and applied at construction.
ModuleEditElement,ModuleEditScreen,AdvancedSettingScreenandKeybindScreenupdated to match.3. Team detection decoupled from
EntityUtils.isTeammate/shouldCancelCcsAttackand the scoreboard/color-name checks movedout of
EntityUtilsintoTeamDetector, so the util no longer imports a module;the ccs macro callers are repointed.
TeamDetectornow caches the parsed manualname list, ignores blank entries, and never flags yourself as a teammate.
4.
NoResPackno longer hangs on forced packs.After blocking a pushed resource pack it now spoofs the accepted → downloaded →
successfully-loaded handshake, so servers stop waiting on a response and kicking.
5.
EntityIndicatorsetting visibility.sprite-sizeonly shows in COMPASS render mode (it has no effect in spherical).Related issues
N/A
Checklist: