Skip to content

fix(expo): internal import ClerkExpo so ios build works with Expo SDK 56#8924

Closed
tombryden wants to merge 1 commit into
clerk:mainfrom
tombryden:main
Closed

fix(expo): internal import ClerkExpo so ios build works with Expo SDK 56#8924
tombryden wants to merge 1 commit into
clerk:mainfrom
tombryden:main

Conversation

@tombryden

@tombryden tombryden commented Jun 18, 2026

Copy link
Copy Markdown

Description

Adds internal to import ClerkExpo to fix ios development build failure with expo sdk 56. Error: ambiguous implicit access level for import of 'ClerkExpo'; it is imported as 'internal' elsewhere

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Internal module import optimization for improved code organization.

Note: This release contains no user-facing changes.

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe16a3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

@tombryden is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 11c105b8-475f-466c-ab98-0ca29d63f458

📥 Commits

Reviewing files that changed from the base of the PR and between 88525a6 and fe16a3b.

📒 Files selected for processing (1)
  • packages/expo/ios/ClerkNativeBridge.swift

📝 Walkthrough

Walkthrough

In ClerkNativeBridge.swift, the import ClerkExpo declaration is changed to internal import ClerkExpo, restricting the module's visibility to the internal access level.

Changes

ClerkExpo Module Import Visibility

Layer / File(s) Summary
ClerkExpo internal import
packages/expo/ios/ClerkNativeBridge.swift
The import ClerkExpo statement is updated to internal import ClerkExpo to explicitly set the module's access level to internal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A single word slipped into place,
internal now guards the space.
The bridge stands firm, the module neat,
One quiet change — a tidy feat.
🐇 hops away satisfied

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding an internal import for ClerkExpo to fix an iOS build issue with Expo SDK 56.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano

wobsoriano commented Jun 19, 2026

Copy link
Copy Markdown
Member

Hi! Can you try installing the latest version (3.4.7) and let me know if you're still seeing the error?

@tombryden

tombryden commented Jun 19, 2026

Copy link
Copy Markdown
Author

Hi! Can you try installing the latest version (3.4.7) and let me know if you're still seeing the error?

Hello! Can see #8927 addresses the issue.

This issue persisted when using 3.4.7 (I haven't patched with the above PR to test though - can only do this later today). Thanks

@wobsoriano

wobsoriano commented Jun 19, 2026

Copy link
Copy Markdown
Member

Hi! Can you try installing the latest version (3.4.7) and let me know if you're still seeing the error?

Hello! Can see #8927 addresses the issue.

This issue persisted when using 3.4.7 (I haven't patched with the above PR to test though - can only do this later today). Thanks

Here's the snapshot for the mentioned PR! npm i https://pkg.pr.new/@clerk/expo@8927

Feel free to test and let us know

@tombryden

Copy link
Copy Markdown
Author

Hi! Can you try installing the latest version (3.4.7) and let me know if you're still seeing the error?

Hello! Can see #8927 addresses the issue.
This issue persisted when using 3.4.7 (I haven't patched with the above PR to test though - can only do this later today). Thanks

Here's the snapshot for the mentioned PR! npm i https://pkg.pr.new/@clerk/expo@8927

Feel free to test and let us know

Great, gave it a quick test and all works as expected. Thanks! 👍

@tombryden tombryden closed this Jun 19, 2026
@mikepitre

Copy link
Copy Markdown
Contributor

@tombryden this is now available in 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants