Conversation
fixing error hanlding in cli.py entry
actually added `useReasoning` common param
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 64.36% 64.49% +0.12%
==========================================
Files 9 9
Lines 1145 1149 +4
==========================================
+ Hits 737 741 +4
Misses 408 408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This patch includes critical bugfixes. See changes below.
Changes
annotate()(and_annotate()) when running an app via cli.py (ZeroDivisionError with empty video document #297)useReasoningcommon parameter for promptable apps (actually addeduseReasoningcommon param #299) Note that release 1.7.2 was supposed to include this parameter (and the release note says so), but it was omitted by mistake.