feat(core): Add bytesLen and bytesLenUnsafe utilities (#353)#392
Merged
Conversation
🦋 Changeset detectedLatest commit: 98597b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR adds byte-length helper utilities to the core hex module, intended to efficiently compute the byte size of HexLike inputs (with a fast-path for validated Hex strings), and publishes the change via a changeset.
Changes:
- Add
bytesLen(hexLike)utility that returns the byte length of aHexLikevalue. - Add
bytesLenUnsafe(hex)utility that computes byte length directly from a Hex string length (handling odd-digit hex). - Add a changeset bumping
@ckb-ccc/coreas a minor release for the new API.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/core/src/hex/index.ts | Introduces bytesLen and bytesLenUnsafe utilities for computing byte length of hex-like inputs. |
| .changeset/eighty-terms-cry.md | Declares a minor changeset for exposing the new utilities in @ckb-ccc/core. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #353