fix(ui): device touch pass — real geometry for the deferred controls - #533
fix(ui): device touch pass — real geometry for the deferred controls#533chodeus wants to merge 1 commit into
Conversation
Every deferred control gets an honest treatment: real 44px where rows absorb it, 36px + a min-w-pinned expansion where density rules, and documented leave-alones (display-only pills; a chip x whose expansion reached the neighbouring chip's x). Selects reach a real 44px trigger — LogFileSelect/ModuleSelect's inner select was unsized, so the true hit area was ~16px regardless of wrapper. SegmentedControl gains min-w-11 so its expansion can never spill horizontally for any schema label; the gap-0.5 track is safe by construction. Poster-card action bars wrap instead of silently clipping at md/lg widths.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (33)
Comment |
1 participant
What
Every control deferred by the G2 overlap sweep gets an honest treatment: real 44px where rows absorb it, 36px + a min-w-pinned expansion where density rules, and documented leave-alones (display-only pills; the MultiSelect chip × stays at a 36px real ceiling because any expansion reached the neighbouring chip's ×).
<select>was unsized, so the true hit area was ~16px regardless.min-w-11: with a 44px minimum width,max(100%, 44px)collapses to 100%, so its coarse-pointer expansion can never spill horizontally for any schema-driven label. The gap-0.5 track is safe by construction; heights unchanged.Verification
Full frontend battery green ×2 (author + verifier): eslint+schema, stylelint, prettier, Vitest, build, used-vs-emitted class check. Built CSS confirmed emitting the one arbitrary-value rule correctly.
Flagged for later (ledgered)
UnmatchedAssetsPage's two hand-rolled SegmentedControl copies (swap for the shared component + free a11y roles); poster-grid md/lg 3-action density design call; two flex-1 touch-expand segments worth the same min-w hardening.