Conversation
* fix(ui): 44px touch batch + vendor icon layer + dvh truth 70 sub-44px controls treated by the geometry (expand where the ::after can't fight, real touch-target in stacked rows and destructive pairs; tight clusters, gap-1 pill rows and selects flagged, not guessed). Material Symbols loads in a vendor layer so layered sizes finally apply — 133 icons change to their INTENDED sizes (atomically revertable; eyeball before merge). base.css keeps its vh fallback via @supports (lightningcss drops the duplicate form, proven). * fix(review): comment truths, layer parity, and the touch-expand overlap sweep check-tailwind-classes' allowlist comment names index.css (where the Material Symbols import lives). base.css declares the same 7-layer list as tailwind.css — emitted CSS is byte-identical, hash-verified. touch-expand comes off 23 sites where the 44px expansion overlaps a sibling's hit area (flex-wrap pill rows, icon clusters, inline links under inputs — including LabelarrPage's library pills from the review); each site measured against the reach-vs-gap rule, all 23 join the deferred device pass. The 40 isolated sites keep it. * fix(review): segment and filter clusters lose touch-expand SegmentedControl's segments are content-sized and SegmentedField feeds it schema-driven labels, so sub-44px segments can't be ruled out — adjacent expansions overlap across the gap-0.5 track. Same shape on the two UnmatchedAssets type-filter rows. All three join the device pass for real segment geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
develophas drifted behindmain(releases, fixes, dependency bumps). Do not merge this PR — it reports the drift, it does not fix it.developrequires branches be up to date, andhead:maincan never satisfy that without pulling develop's extension files into main, which the branch invariant forbids. Squash or rebase would also leavemainunreachable fromdevelop, so this workflow would just open another PR next push.Sync locally instead:
Then verify
git diff main developis added extension files plusdeploy/docker/Dockerfileonly. GitHub marks this PR merged on its own once develop contains main's tip. Opened by the sync-develop workflow.