Conversation
…#527) * refactor(api): posters.py queries move behind named interface methods All 16 raw-SQL sites route through domain-named cache methods (12 new across PosterCache/MediaCache/CollectionCache; 4 reuse G1's). delete_collection runs items+collection in one transaction; remove_collection_item returns its rowcount for the 404; match approve/reopen drop the f-string table switch for per-cache owners; the dimensions backfill leaves db.worker for its owner. delete_poster's confinement unifies on resolve_confined (a missing file now skips soft instead of raising). Genuine-only non-200 docs on the touched routes. * fix(codeql): route mutations happen outside the asserts py/side-effect-in-assert (314/315): under -O the assert strips and the DELETE/POST never fires. All four route-mutation asserts in the new test file hoist the call and assert the captured response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
develophas drifted behindmain(releases, fixes, dependency bumps). Do not merge this PR — it reports the drift, it does not fix it.developrequires branches be up to date, andhead:maincan never satisfy that without pulling develop's extension files into main, which the branch invariant forbids. Squash or rebase would also leavemainunreachable fromdevelop, so this workflow would just open another PR next push.Sync locally instead:
Then verify
git diff main developis added extension files plusdeploy/docker/Dockerfileonly. GitHub marks this PR merged on its own once develop contains main's tip. Opened by the sync-develop workflow.