Conversation
…523) * refactor(api): media_api queries move behind named interface methods All 11 raw-SQL sites route through domain-named owners (12 new methods; media_edit_history and poster_collections gain their owning interfaces), restoring the DBWorker table allowlist these calls bypassed. Genuine-only non-200 response docs ride along. path_safety.resolve_confined() gives path confinement one documented owner (the recurring py/path-injection FP anchor) and the regression-test import is single-style again. * fix(codeql): normalize resolve_confined via os.path.realpath py/path-injection models Path.resolve() as a filesystem sink, so the confinement owner minted alert 312 itself; os.path.realpath is the same normalization outside the sink model. Docstring to the one-line cap. Alert 313: pass ChubConfig directly instead of a lambda wrapper. * fix(review): collection key, id recovery, purge truth, deterministic pages get_by_title_and_instance carries library_name (unique-key member; IS ? matches the NULL-library row). create_collection returns its insert id so the tag flow can't adopt a concurrent namesake's row. delete_by_ids chunks at 500 and the purge route reports rows actually deleted. Shared is_missing_value predicate owns the empty-field rule. find_low_rated, find_incomplete_metadata and get_edit_history gain unique tiebreakers (one metadata PUT writes several rows with one timestamp). find_by_tag matches the quoted JSON element, not any substring. Chunk test reads the build's real variable limit instead of assuming the compile default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
develophas drifted behindmain(releases, fixes, dependency bumps). Do not merge this PR — it reports the drift, it does not fix it.developrequires branches be up to date, andhead:maincan never satisfy that without pulling develop's extension files into main, which the branch invariant forbids. Squash or rebase would also leavemainunreachable fromdevelop, so this workflow would just open another PR next push.Sync locally instead:
Then verify
git diff main developis added extension files plusdeploy/docker/Dockerfileonly. GitHub marks this PR merged on its own once develop contains main's tip. Opened by the sync-develop workflow.