Skip to content

fix(ci): develop-invariant guard — pure-insertion Dockerfile check, not byte-prefix - #505

Merged
chodeus merged 1 commit into
mainfrom
ci/fix-develop-invariant-check
Aug 11, 2026
Merged

fix(ci): develop-invariant guard — pure-insertion Dockerfile check, not byte-prefix#505
chodeus merged 1 commit into
mainfrom
ci/fix-develop-invariant-check

Conversation

@chodeus

@chodeus chodeus commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

Regression hotfix for the develop-invariant-guard from #503. The byte-prefix Dockerfile check (adopted from a CodeRabbit round-2 suggestion) false-fails legitimate develop state: the CL2K blocks are inserted mid-file into the right build stages (pip deps in the pip stage, fonts in the apt stage), which the documented invariant explicitly allows ("pure-insertion hunks"). Verified against real data: develop's Dockerfile has 0 deletion lines vs main (passes the insertion check) but fails the prefix check — currently failing sync PR #502 and blocking develop image publishing via docker-push's needs.

Restores the pure-insertion-hunks check (git diff origin/main...HEAD -- deploy/docker/Dockerfile | grep '^-[^-]') — the form reviewed in round 1 — with a comment recording why byte-prefix is wrong here.

Type of change

  • Bug fix (non-breaking)

Testing

Simulated both guard clauses against real origin/develop: name-status PASS, insertion-check PASS (the exact case failing on #502). YAML + actionlint clean.

…ot byte-prefix

The CL2K blocks are inserted mid-file (per build stage), which the documented
invariant allows (pure-insertion hunks). The byte-prefix check false-failed
every develop-bound ref, blocking the sync PR and develop image publishing.
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a08398d5-b45c-400c-bcfc-6e234c922a67

📥 Commits

Reviewing files that changed from the base of the PR and between 4009c1c and 834e62b.

📒 Files selected for processing (1)
  • .github/workflows/codeql-lint.yml

Comment @coderabbitai help to get the list of available commands.

@chodeus
chodeus merged commit b3a2b59 into main Aug 11, 2026
27 checks passed
@chodeus
chodeus deleted the ci/fix-develop-invariant-check branch August 11, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant