feat: Compact whitespace in db.query.text by default - #34
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #34 +/- ##
========================================
Coverage 99.95% 99.96%
========================================
Files 12 13 +1
Lines 2182 2552 +370
========================================
+ Hits 2181 2551 +370
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Both QueryTextMode::Full (default) and QueryTextMode::Obfuscated now collapse inter-token whitespace runs to a single space and trim leading/trailing whitespace before emitting db.query.text. Whitespace inside string literals, quoted identifiers, dollar-quoted bodies, and comments is preserved verbatim. Multi-line SQL written for source-level readability now renders as a single readable line in OTel exports without padding the captured value with embedded `\n` and indentation runs. QueryTextMode::Off is unchanged. The new compact_whitespace pass runs at the executor dispatch site as `compact_whitespace(sql)` for Full and `compact_whitespace(obfuscate(sql))` for Obfuscated, keeping value redaction and whitespace cosmetics decoupled.
chmodas
force-pushed
the
query-text-compaction
branch
from
May 4, 2026 20:54
dd2fcb9 to
f8fc91f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both QueryTextMode::Full (default) and QueryTextMode::Obfuscated now collapse inter-token whitespace runs to a single space and trim leading/trailing whitespace before emitting db.query.text. Whitespace inside string literals, quoted identifiers, dollar-quoted bodies, and comments is preserved verbatim. Multi-line SQL written for source-level readability now renders as a single readable line in OTel exports without padding the captured value with embedded
\nand indentation runs. QueryTextMode::Off is unchanged.The new compact_whitespace pass runs at the executor dispatch site as
compact_whitespace(sql)for Full andcompact_whitespace(obfuscate(sql))for Obfuscated, keeping value redaction and whitespace cosmetics decoupled.