chore: update rusqlite from 0.37 to 0.40#8413
Draft
link2xt wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
Well, this requires MSRV 1.95 because this is where |
link2xt
force-pushed
the
link2xt/rusqlite-0.40
branch
3 times, most recently
from
ec2b088 to
4deae62
Compare
Largest change comes from removal of u64 and usize serialization in rusqlite 0.38.0. It is possible to enable it back with `fallible_uint` feature as suggested in rusqlite/rusqlite#1732, but there is a good reason for this change as it may result in unexpected failures when trying to store u64 integers that don't fit in i64, so I don't enable it back. With this change conversions between i64 and u64 are explicit. Using less `usize` is generally good as its size differs on 32-bit platforms that are rarely tested but still supported and we have changes that reduce its usage such as 0defa11, 014d2ac etc.
link2xt
force-pushed
the
link2xt/rusqlite-0.40
branch
from
4deae62 to
da3f434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largest change comes from removal of u64 and usize serialization in rusqlite 0.38.0.
It is possible to enable it back with
fallible_uintfeature as suggested in rusqlite/rusqlite#1732, but there is a good reason for this changeas it may result in unexpected failures when
trying to store u64 integers that don't fit in i64, so I don't enable it back.
With this change conversions between i64 and u64 are explicit.
Using less
usizeis generally good as its sizediffers on 32-bit platforms that are rarely tested but still supported and we have changes that reduce its usage such as 0defa11,
014d2ac etc.