api!: delete_transport() must not be used by UIs anymore. Instead, set_transport_unpublished() must be called when a user clicks on "Remove"#8408
Merged
Conversation
…`set_transport_unpublished()` must be called when a user clicks on "Remove" I marked this as a breaking change so that it visibly appears in the changelog.
Contributor
|
I also modified docs in #8402 - maybe we should combine these? |
r10s
approved these changes
Jul 8, 2026
BREAKING CHANGE: UIs should use `list_transports()` rather than `list_transports_ex()`, because unpublished transports count as removed from the user point of view, and should not be shown in the relay list anymore.
Collaborator
Author
|
@j-g00da you can just rebase #8402 as soon as the PR here is merged - in general, unfortunately we have some of the documentation duplicated, so you need to make sure to update all of the doc comments when updating documentation:
I accidentally merged #8409 first so that it got merged into the PR here, but it doesn't matter, I'll rebase-merge now so that the two PRs get merged as two commits into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it clear that from now on, UIs must use
set_transport_unpublished()instead ofdelete_transport().Companion PR for #8402, related to #8384
I marked this as a breaking change so that it visibly appears in the changelog.