fix(tag-db): rm -f so first-time tag DB upload works - #41
Merged
Conversation
The handler deletes /data/sg_files/SG_tag_database* before writing the new file. On a station that has no tag DB yet the glob matches nothing, so plain rm exits non-zero; RunCommand rejects and the upload aborts before fs.writeFileSync runs, surfacing "Command failed: rm ... No such file or directory". Use rm -f so an empty match is treated as success. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Uploading a SensorGnome tag database on a station that has no existing tag DB fails with:
Root cause
upload-sg-tag-file.jsrunsrm /data/sg_files/SG_tag_database*before writing the new file. When no tag DB exists yet, the glob matches nothing, plainrmexits non-zero,RunCommandrejects, and the handler aborts in.catchbeforefs.writeFileSyncever runs. Confirmed on a v3r0 station (lts_24_06 line) at upload time.Fix
Use
rm -f, which treats "nothing to remove" as success. Verified end-to-end on-device:POST /upload-sg-tag-file→{"res":true}/ 200 and the file is written.Context
Follow-up to the
fsimport fix (PR #40, already merged here). Sibling change for thelts_24-06.isoline is in PR #39. The fs-import PR for this branch (#40) was already merged and its branch deleted, so this is a fresh PR rather than an update.🤖 Generated with Claude Code