Skip to content

CELDEV-1332 - Consume the shared messages web overlay #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fpichler wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

CELDEV-1332 - Consume the shared messages web overlay #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b88a2b
CELDEV-1332 Add message API endpoints
fpichler Jul 31, 2026
ba7099c
CELDEV-1332 consume messages overlay
fpichler Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions celements-webapp/Jenkinsfile.release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ releasePipeline(manifest: [
'celements-rte-tiny6-war',
'celements-rte-langs-tiny4-war',
'celements-rte-langs-tiny6-war',
'celements-messages-jar',
'celements-messages-web',
'celements-webapp-war',
],
])
5 changes: 5 additions & 0 deletions celements-webapp/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,11 @@
<groupId>com.celements</groupId>
<artifactId>celements-spring-mvc</artifactId>
</dependency>
<dependency>
<groupId>com.celements</groupId>
<artifactId>celements-messages-web</artifactId>
<type>war</type>
</dependency>
<dependency>
<groupId>com.celements</groupId>
<artifactId>celements-spring-security</artifactId>
Expand Down
8 changes: 2 additions & 6 deletions celements-webapp/src/main/webapp/resources/celJS/initCelements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,12 +484,8 @@
window.celMessages.isLoaded = false;

try {
new Ajax.Request(window.getCelHost(), {
method: 'post',
parameters: {
xpage: 'celements_ajax',
ajax_mode: 'Messages',
},
new Ajax.Request('/api/v1/messages', {
method: 'get',
onSuccess: function (transport) {
if (transport.responseText.isJSON()) {
const newMessages = transport.responseText.evalJSON();
Expand Down
2 changes: 1 addition & 1 deletion celements-webapp/src/main/webapp/resources/celJS/initCelements.min.js
View file
Open in desktop

@cbspichler cbspichler Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: What's the need behind checking in minified files and keeping them in sync manually with the normal files?

Large diffs are not rendered by default.

8 changes: 2 additions & 6 deletions celements-webapp/src/main/webapp/resources/celJS/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,12 +539,8 @@
['validate-docname', null, Validator.methods.validDocName],
];

new Ajax.Request(getCelHost(), {
method: 'post',
parameters: {
xpage: 'celements_ajax',
ajax_mode: 'ValidationMessages',
},
new Ajax.Request('/api/v1/messages/validation', {
method: 'get',
onSuccess: function (transport) {
if (transport.responseText.isJSON()) {
Validation.messages = Validation.messages.merge(transport.responseText.evalJSON());
Expand Down
5 changes: 0 additions & 5 deletions celements-webapp/src/main/webapp/templates/celAjax/Messages.vm
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions celements-webapp/src/main/webapp/templates/celAjax/ValidationMessages.vm
View file
Open in desktop

This file was deleted.

215 changes: 0 additions & 215 deletions celements-webapp/src/main/webapp/templates/celMacros/CelMessages.vm
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions celements-webapp/src/main/webapp/templates/celMacros/CelValidationMessages.vm
View file
Open in desktop

This file was deleted.