Skip to content

e2e DateTransform Plugin related testcases#1618

Closed
Swati10-11 wants to merge 2 commits into
cdapio:developfrom
Swati10-11:e2e-date-transform
Closed

e2e DateTransform Plugin related testcases#1618
Swati10-11 wants to merge 2 commits into
cdapio:developfrom
Swati10-11:e2e-date-transform

Conversation

@Swati10-11

@Swati10-11 Swati10-11 commented May 5, 2022

Copy link
Copy Markdown

@google-cla

google-cla Bot commented May 5, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

rmstar
rmstar reviewed May 24, 2022
View reviewed changes

@rmstar rmstar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date transform plugin needs to be downloaded from the hub. How are we handling that step when running using Github actions?

Comment thread e2e-test/src/test/resources/pluginDataCyAttributes.properties Outdated
formatMacroInput=format
sampleSize=sampleSize
delimiter=delimiter
skipHeader=switch-skipHeader

@rmstar rmstar May 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove configs that are not relevant to date transform plugin

@Swati10-11 Swati10-11 May 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment thread e2e-test/src/test/resources/pluginParameters.properties Outdated
@@ -0,0 +1,18 @@
projectId=cdf-athena
dataset=test_automation
csvFormat=csv

@rmstar rmstar May 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove irrelevant configs

@Swati10-11 Swati10-11 May 24, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@itsankit-google

itsankit-google commented May 24, 2022

Copy link
Copy Markdown
Member

Date transform plugin needs to be downloaded from the hub. How are we handling that step when running using Github actions?

Using the run_e2e_test script, we deploy the latest build plugin, why will we need to download it from hub?
https://github.com/cdapio/cdap-e2e-tests/blob/develop/src/main/scripts/run_e2e_test.py#L70

@itsankit-google itsankit-google added the build Trigger unit test build label May 24, 2022
itsankit-google
itsankit-google reviewed May 24, 2022
View reviewed changes

@itsankit-google itsankit-google left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests should be added in respective plugin modules instead of the parent? @ksahilCF

@Swati10-11

Swati10-11 commented May 24, 2022

Copy link
Copy Markdown
Author

New PR raised
data-integrations/date-transform#15

@Swati10-11 Swati10-11 closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmstar rmstar rmstar left review comments
@itsankit-google itsankit-google itsankit-google left review comments

Assignees

No one assigned

Labels

build Trigger unit test build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Swati10-11 @itsankit-google @rmstar