Fix dropping of error locations#37
Merged
Merged
Conversation
Collaborator
|
Cool! I did find an issue in the meantime, but I have yet to make a minimal reproducer out of it. I'll have a look. Perhaps for testing you can use this structure: and That way it doesn't just run in Nix. |
cchalmers
force-pushed
the
fix-error-locations
branch
from
b6fd712 to
f83ef95
Compare
Since #14 the error locations often pointed to the end of the circuit instead of the correct location. Locate each generated binding at its circuit expression so GHC blames the offending statement. The regression test is in a separate PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Compiles tests/fixtures/BusError.hs (a deliberate type error on a bus) with the plugin enabled and asserts that GHC reports the error on the offending line rather than at the end of the circuit block. Under cabal the plugin is found via the package environment file. Under `nix build` the package isn't registered in a package db during its own check phase, so the flake points GHC_PACKAGE_PATH (via the builder's NIX_GHC_PACKAGE_PATH_FOR_TEST hook) at the in-place db, letting the test run for real there too. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cchalmers
force-pushed
the
fix-error-locations
branch
from
f83ef95 to
36c873b
Compare
Owner
Author
|
I've scaled back the CI changes to the minimum needed for nix to work. The multi-ghc nix support can come in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14 the error locations often pointed to the end of the circuit instead of the correct location. That should now be fixed, along with a regression test.
Hopefully resolves #35.