Improve deciles for ratio curves - #17
Merged
Merged
Conversation
Damonamajor
marked this pull request as ready for review
August 3, 2026 19:49
wrridgeway
approved these changes
Aug 3, 2026
wrridgeway
left a comment
Member
There was a problem hiding this comment.
Thank you for catching this issue @Damonamajor ! I've got some minor suggestions below for consistency, but make sure to test any of them after committing.
wrridgeway
reviewed
Aug 3, 2026
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Contributor
Author
|
@ccao-jardine updated outputs are here if you want to look at them for Bremen |
Member
Member
|
My comment above looks resolved, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We were not getting a ratio value for the 1st decile once
excluded saleswere removed from the spreadsheet.My initial assumption was that we had too few sales in the 1st decile grouping, but I don't think that's right. My next hunch is that it involves NA sales which calculate NA ratios. I'm still investigating this slightly.
Pretty sure it was in this line
median(desk_review_sale_ratio)which doesn't remove NA values.However, this standardizes all the ratio calculations to remove the sales which res-val include in their exclusion list including the map, ratio stats, and the ratio curve.
I asked when the requestor wanted the file and they said by EOD tomorrow.