Skip to content

Improve deciles for ratio curves - #17

Merged
Damonamajor merged 11 commits into
mainfrom
improve-deciles-for-ratio-curves
Aug 5, 2026
Merged

Improve deciles for ratio curves#17
Damonamajor merged 11 commits into
mainfrom
improve-deciles-for-ratio-curves

Conversation

@Damonamajor

@Damonamajor Damonamajor commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

We were not getting a ratio value for the 1st decile once excluded sales were removed from the spreadsheet.

My initial assumption was that we had too few sales in the 1st decile grouping, but I don't think that's right. My next hunch is that it involves NA sales which calculate NA ratios. I'm still investigating this slightly.

Pretty sure it was in this line
median(desk_review_sale_ratio) which doesn't remove NA values.

However, this standardizes all the ratio calculations to remove the sales which res-val include in their exclusion list including the map, ratio stats, and the ratio curve.

I asked when the requestor wanted the file and they said by EOD tomorrow.

@Damonamajor
Damonamajor marked this pull request as ready for review August 3, 2026 19:49
@Damonamajor
Damonamajor requested a review from a team as a code owner August 3, 2026 19:49

@wrridgeway wrridgeway left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this issue @Damonamajor ! I've got some minor suggestions below for consistency, but make sure to test any of them after committing.

Comment thread provisional-ratio-curves/provisional-ratio-curves.R
Comment thread provisional-ratio-curves/provisional-ratio-curves.R Outdated
Comment thread provisional-ratio-curves/provisional-ratio-curves.R Outdated
Damonamajor and others added 4 commits August 3, 2026 16:13
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
@Damonamajor

Copy link
Copy Markdown
Contributor Author

@ccao-jardine updated outputs are here if you want to look at them for Bremen
O:\CCAODATA\recurring-data-requests\provisional-ratio-curves\output\2026

@ccao-jardine

Copy link
Copy Markdown
Member

Hmm, can we get some extra QC of the "Ratio Deciles" and "All Parcels" sheets in the excel file?

In "All Parcels", sorted to Price Decile = 1, I'm seeing prices that don't seem appropriate for this bin (note I've added some formatting for readability):
image

In "Ratio Deciles" I'm seeing overlapping price ranges:
image

The png has what appear to be appropriate ranges, but I'm nervous that its bins disagree with the bins in the excel file:

image

@ccao-jardine

Copy link
Copy Markdown
Member

My comment above looks resolved, thanks!

@Damonamajor
Damonamajor merged commit efd5e54 into main Aug 5, 2026
3 checks passed
@Damonamajor
Damonamajor deleted the improve-deciles-for-ratio-curves branch August 5, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants