sync#1085
Merged
Merged
Conversation
# Conflicts: # chainladder/core/typing.py
Dunders tests
Pandas annotations
DOCS: Add ARCHITECTURE.md.
TEST: Add tests for base.py
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 39.1% fully typed (9 / 23); 3 no longer exported
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experimental #1085 +/- ##
================================================
+ Coverage 89.75% 90.18% +0.42%
================================================
Files 91 91
Lines 5408 5409 +1
Branches 696 696
================================================
+ Hits 4854 4878 +24
+ Misses 389 375 -14
+ Partials 165 156 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Changes are documentation, static typing, and tests with no intentional reserve-calculation behavior changes; dependency pin is a minor compatibility guard.
Overview
Adds
ARCHITECTURE.mddocumenting package layout, the Triangle mixin stack, composition of indexers, and theTYPE_CHECKING+TriangleProtocolpattern for mixins without runtime Protocol MRO issues.Typing:
TrianglePandasnow uses a conditional_TrianglePandasBase(TriangleProtocolunderTYPE_CHECKING,objectat runtime).TriangleProtocolgains axis setters,__round__, and stricterfillnatyping;_auto_sparse()is annotated to returnTriangle. The pandas-style API onTrianglePandasgets clearer return types and small cleanups (rounddelegates to__round__,pct_chgDataFrame passthrough,concatimport at module level).Tests: Broad new coverage for arithmetic unions/broadcasting,
__array__/__array_function__, auto-sparse behavior, polars__dataframe__init, invalid origin/development rows, and related edge cases.Deps:
uv.lockcaps pandas at<=3.0.3.Reviewed by Cursor Bugbot for commit 55f9524. Bugbot is set up for automated code reviews on this repo. Configure here.