Skip to content

Add test case for CcpCrashOnPurpose#32

Open
CCP-Aporia wants to merge 1 commit into
mainfrom
add-tests-for-ccpcrash
Open

Add test case for CcpCrashOnPurpose#32
CCP-Aporia wants to merge 1 commit into
mainfrom
add-tests-for-ccpcrash

Conversation

@CCP-Aporia

Copy link
Copy Markdown
Member

Good to have a test for this because its behaviour may change depending on the platform it runs on.

Good to have a test for this because its behaviour may change depending on the platform it runs on.

@ccp-serpent ccp-serpent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem with this addition in isolation.

Before accepting I'm curious about your opinion on whether something like this should exist in Exefile instead? That way, we could potentially extend our code coverage to our crashpad integration while achieving the same results as outlined in this PR.

@CCP-Aporia

Copy link
Copy Markdown
Member Author

I see no problem with this addition in isolation.

Before accepting I'm curious about your opinion on whether something like this should exist in Exefile instead? That way, we could potentially extend our code coverage to our crashpad integration while achieving the same results as outlined in this PR.

This isn't testing crash dump functionality, this is only testing that core's ability to force a crash works. Adding relevant tests for the crashpad integration is a good idea, but should happen in addition to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants