fix(uploads): lower multipart upload threshold to 10 MB - #204
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the app bundle file upload behavior so multipart uploads start at 10 MB (instead of 50 MB), aligning the cutoff with the existing 10 MB part size used by the multipart upload implementation.
Changes:
- Lowered the multipart upload threshold for app bundle files from 50 MB to 10 MB.
- Preserved the existing behavior where files under the threshold are uploaded inline via
FormData, while files at/over the threshold are uploaded in parts.
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App bundle files switched to a multipart upload only from 50 MB. This lowers that threshold to 10 MB, so it now matches the part size used by
createUploadParts.Files below 10 MB are still sent inline in the
FormDataof the create request; from 10 MB the file is uploaded in parts.Note:
app-build-sources.tsis unchanged and still always uses a multipart upload. Its create endpoint only acceptsfileSizeInBytesorfileUrl, so there is no inline-file path to fall back to for small files.