eds: Style cleanup and simplification, warning fixes#675
Open
acolomb wants to merge 11 commits into
Open
Conversation
Rename "match" variable, which is a language keyword.
Follow a common pattern of retrieving a raw_string from the parsed EDS outside of the block for catching ValueError, which is not raised from the RawConfigParser call. Fixes some type checker errors. Some more need to be squelched, for custom attribute additions.
Follow the mypy advice about incompatible type. Silence the method assignment error, as that's a legitimate an documented use case on this class.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
Author
|
I have another PR branch prepared which is based on top of this one. It adds a "strict" mode flag where EDS importing raises exceptions instead of just logging warnings. See this branch, which will be submitted as PR once this cleanup is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not result in any functional behavior changes. It mainly fixes some of the clumsy code in eds.py and avoids type checker errors in the process.
See individual commit messages for more details on the changes.