Release Review: NetworkAccessManagement r3.1 (rc Sync26)#169
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 61 hints | Profile: standard |
Updated the changelog for the network-access-devices and network-access-domains APIs, detailing breaking changes, additions, modifications, and the new input-validation response.
|
@tanjadegroot As recommended in PR #164, that PR was discarded, issue #165 was fixed and merged. This PR is the follow-on snapshot. |
tanjadegroot
left a comment
There was a problem hiding this comment.
Hi team,
please see comments on teh changelog and readme that can be fixed on this PR. *
After that you should be fine for release.
There was a problem hiding this comment.
The introduction of the new error code 409 INCOMPATIBLE STATE in the OAS is listed as a breaking change and should be documented in the changelog both in the "Breaking changes" and in the "Added" sections. Same for documenting the removal of the 409 CONFLICT in "Breaking changes" and 'Removed" sections.
There are a few "feat:" changes listed in the candidate changes section that you may want to copy to the changelog "Added" section.
Similarly, some of the "fix:" ones could be copied to the "Fixed" section if useful for the API consumers.
There was a problem hiding this comment.
You may want to slightly extend the scope section of the README to reflect the functionality of the 2 APIs.
…note deviceStatus; extend README scope
|
Thanks @tanjadegroot — I've updated the CHANGELOG on this PR to address the review:
|
@clundie-CL Hi Cody, it looks great now. Many thanks for the updates. I will approve the PR. |
| * **Network Access Domains** — create and manage Trust Domains (declarative LAN-like network segments) with their access and policy configuration, register and onboard subscriber/IoT devices into them, and enumerate the subscriber's services and service sites. | ||
| * **Network Access Devices** — enumerate operator-supplied network access equipment (and its reported status) and request immediate or scheduled device reboots. |
There was a problem hiding this comment.
@tanjadegroot I noticed that this is not part of the post-release sync to main PR #170. Is that expected or a release automation gap?
Not a major issue, can always manually reconcile what was added to the release tag back onto main, but my reaction at a glance is that if a README is adjusted on a release PR to the snapshot branch, that this would also sync back to main.
There was a problem hiding this comment.
Hmm, good catch, you are probably right on that one. Will check with @hdamker what should be done here. Either only automated changes to the README in the Release Review PR and manual updates to README on main only, or synch back to main if updates are allowed. It could be my bad on the recommendation to change it in the release review PR (in which case my apologies).
Release Review: r3.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.3.0-rc.1N/A0.3.0-rc.1N/ADependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r3.1-d1b328d