ci(workflows): pin build container images - #287
Draft
dc-tec wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Roel de Cort <roel.decort@adfinis.com>
Contributor
Author
|
This looks like a flaky failing test, could you retrigger the failing jobs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This covers 11 references to five unique images across the .NET, FFI, Go, and Node workflows.
Rationale
The workflows previously referenced mutable container tags. A registry publisher could therefore change the bytes used by pull-request and release builds without any corresponding repository change or review.
Zizmor reported eight high/high
unpinned-imagesfindings across the four matrix-container workflows. Pinning the resolved manifests makes image changes explicit and reviewable while retaining the original platform and compatibility tags.No build behavior is intended to change beyond fixing the images to the versions the existing tags resolved to when this change was prepared.
Maintenance tradeoff
This trades silent upstream image drift for manual refreshes.
Dependabot currently only extracts repository-style
uses:dependencies from GitHub Actions workflows. It does not update job-container matrix values or image references embedded indocker runcommands. Adding a Docker ecosystem entry would not cover these workflow files either.There are five unique images behind the 11 references, so a refresh is mechanical but must currently be initiated manually. I have intentionally not added another dependency bot or prescribed an update schedule in this PR.
A reasonable initial policy could be to refresh these pins during release preparation, in response to relevant security notices, or on an agreed periodic cadence. If that proves burdensome, a dedicated updater or consistency check can follow.
Dependabot support reference
Validation
linux/amd64linux/arm64devenv shell -- actionlint -shellcheck=devenv shell -- pre-commit run -aunpinned-imagesfindings are no longer reportedZizmor still emits four low-confidence
unpinned-imagesfindings because it cannot statically prove thatmatrix.containeronly resolves to the pinned matrix values. The concrete values are all digest-pinned.