fix(webconsole): remediate security risk summary vulnerabilities - #1112
Merged
Conversation
Addresses the five issues in docs/soc_risk_summary.md: 1. FilesApi directory traversal: canonicalize the requested directory via realpath + commonpath and reject any path that escapes STORAGE_ROOT. 2. Missing @jwt_required on DatasetPreviewApi and DatasetMetricsApi. 3. DatasetsApi cross-tenant listing (IDOR): require an explicit and existing project id before returning any datasets. 4. Workflow variables PodSpec injection: JSON-escape user-provided STRING variables when they are interpolated into a job yaml template so they cannot break out of the enclosing string and inject PodSpec fields. 5. GRPC_SSL_SERVER_HOST nginx annotation CRLF/config injection: validate the value against a strict FQDN charset on both project create and update paths. 6. sparkapps name path traversal: enforce a DNS-label allowlist for the sparkapp name and re-check with realpath + commonpath that the resulting upload path stays inside self._base_dir; guard the clear-and-recreate operation the same way. 7. DEBUG env var JWT bypass: parse DEBUG as a strict boolean so values like the string "False" no longer disable auth; additionally require FLASK_ENV != production before honoring the debug bypass in jwt_required.
Shane1117
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the five issues in docs/soc_risk_summary.md: