chore(git): stop tracking pubspec.lock in library packages#40
chore(git): stop tracking pubspec.lock in library packages#40cemal-yilmaz-bt wants to merge 1 commit into
Conversation
Library packages must not commit pubspec.lock (consumers resolve their own versions); only apps/poc keep theirs. Part of the microSDK handover lockfile-hygiene standardization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideStops tracking pubspec.lock for Dart library packages under packages/dart/* by adding a scoped .gitignore rule and removing the lockfiles from version control while leaving app lockfiles intact. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesGitignore Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file to prevent committing pubspec.lock files for Dart library packages, and removes an existing pubspec.lock file from the repository. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If the new
.gitignorerule is currently global, consider scoping it explicitly topackages/dart/*/pubspec.lockso app lockfiles (likepoc/flutter-poc) can’t be accidentally ignored in the future.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the new `.gitignore` rule is currently global, consider scoping it explicitly to `packages/dart/*/pubspec.lock` so app lockfiles (like `poc/flutter-poc`) can’t be accidentally ignored in the future.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
What
Stop tracking
pubspec.lockfor the library packages underpackages/dart/*(morph_core,morph_logger,morph_oauth2,morph_storage). Adds a scoped.gitignorerule andgit rm --cacheds the four locks (files stay on disk).poc/flutter-poc(an app) keeps its committed lock.Why
Dart convention: libraries must not pin their dependency graph — consumers resolve their own versions; a committed library lock is meaningless downstream and only creates churn. Part of the microSDK handover lockfile-hygiene standardization (matching
vnext-client-workflow-manager).Safety
No CI/tooling depends on these locks — all jobs use plain
dart pub get(no--enforce-lockfile). Verifieddart pub getregenerates the now-ignored lock with a clean working tree.🤖 Generated with Claude Code
Summary by Sourcery
Stop tracking Dart library package pubspec.lock files and ignore them in Git.
Chores:
Summary by CodeRabbit