Skip to content

docs(dart): align morph_core and morph_storage package metadata (#33) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cemal-yilmaz-bt merged 1 commit into from
May 4, 2026
Merged

docs(dart): align morph_core and morph_storage package metadata (#33) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/dart/morph_core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@ Dart port of **`@morph/core`** (Morph API Client). See
`packages/ts/core/src/config/validate.ts` (throws **`ConfigValidationError`** with
aggregated messages).
- **`normalizeExchangeSources`**, **`listAuthIdsForProvider`** — parity with TS helpers.
- **`MorphClient.init`** — runs config validation, then throws **`UnimplementedError`**
until runtime / OAuth / HTTP / plugins are ported ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)).
- **`MorphClient`**, **`MorphRuntime`**, plugin install (**`provides` / `requires`**),
**`HostPipeline.hostFetch`**, and **`MorphPlugin`** surface — shipped; mirrors TS
client/runtime/pipeline behavior per **`docs/dart-parity.md`**.
- Public OAuth helpers (authorize URL, OAuth state/return utilities), JWT helpers,
and types aligned with **`packages/ts/core`** exports where applicable.

Typed **`MorphConfig` / strong `MorphOptions`** DTOs (vs `Map<String,dynamic>`) are
planned; config is validated as decoded JSON maps for now.
Typed **`MorphConfig` / strong `MorphOptions`** DTOs (vs `Map<String,dynamic>`) remain
**backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)).
Comment on lines +18 to +19

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The README states that MorphOptions DTOs remain in the backlog and compares them to Map<String, dynamic>. However, the current implementation already uses a typed MorphOptions class in the MorphClient.init signature (as seen in packages/dart/morph_core/lib/src/morph_client.dart). This part of the documentation should be updated to reflect that MorphOptions is already implemented as a strong DTO.

Suggested change
Typed **`MorphConfig` / strong `MorphOptions`** DTOs (vs `Map<String,dynamic>`) remain
**backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)).
Typed **`MorphConfig`** DTOs (vs `Map<String,dynamic>`) remain
**backlog**; config is validated as decoded JSON maps for now ([#3](https://github.com/burgan-tech/morph-api-client/issues/3)).


```bash
dart pub get
Expand Down
4 changes: 2 additions & 2 deletions packages/dart/morph_core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: morph_core
description: >
Dart port of @morph/core (Morph API Client). Scaffold: mirrors TypeScript init
shape; OAuth, HTTP pipeline, and plugins unimplemented until parity milestones.
Dart port of @morph/core — MorphClient, config validation, MorphRuntime, HTTP host
pipeline, plugin composition, and shared types (parity with packages/ts/core).
publish_to: "none"
version: 0.1.0

Expand Down
5 changes: 4 additions & 1 deletion packages/dart/morph_storage/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: morph_storage
description: Storage adapters for Morph (Dart parity with @morph/browser-storage).
description: >
In-memory StorageProvider and MorphPlugin for Morph (tests/VM). Browser
session/local storage lives in @morph/browser-storage (TS); production Flutter
apps typically use morph-data-store via morph_core_storage.
publish_to: "none"
version: 0.1.0

Expand Down
Loading