Skip to content

Wait for complete hover-card rendering - #68

Merged
brsbl merged 3 commits into
mainfrom
bb/hover-card-ready-captures-thr_bwikffmsvp
Aug 19, 2026
Merged

Wait for complete hover-card rendering#68
brsbl merged 3 commits into
mainfrom
bb/hover-card-ready-captures-thr_bwikffmsvp

Conversation

@brsbl

@brsbl brsbl commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds an explicit hover-card render state so screenshot and UI automation can wait for every asynchronous section, including timing and pull-request metadata.
  • Marks a card complete only after async enrichment, fonts, images, and two paint frames have settled; error states remain explicit.
  • Preserves the existing hover timing and visual presentation.

Rendering evidence

A cold real-BB render completed in 337 ms: summary 182 ms, timing 41 ms, and pull-request metadata 43 ms. No rendering bottleneck was found, so this PR intentionally makes no speculative performance change.

The matched screenshot fixture delays pull-request metadata by 1.5 seconds. The parent can be captured before the PR section arrives; the branch stays busy until the complete card includes #67 and Merged.

Before — parent captured too early After — complete readiness
Hover card missing its delayed PR section Hover card after every section rendered

Validation

  • npm run check --workspace=bb-plugin-thread-hover-cards
  • git diff --check
  • Real BB dev app at 1440x900 with the same project, thread, viewport, window bounds, and delayed PR fixture on both revisions

BB-Thread-ID: thr_bwikffmsvp

@brsbl
brsbl marked this pull request as ready for review August 19, 2026 18:56
@brsbl
brsbl merged commit e55f448 into main Aug 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant