Skip to content

fix(SDK-6463): robust TS config compile in NX monorepos + tolerate a11y afterEach scan timeouts#1131

Open
Bhargavi-BS wants to merge 2 commits into
masterfrom
sdk-6463-nx-tsconfig-and-a11y-afterEach-fixes
Open

fix(SDK-6463): robust TS config compile in NX monorepos + tolerate a11y afterEach scan timeouts#1131
Bhargavi-BS wants to merge 2 commits into
masterfrom
sdk-6463-nx-tsconfig-and-a11y-afterEach-fixes

Conversation

@Bhargavi-BS

Copy link
Copy Markdown
Collaborator

SDK-6463 — Cypress test-count / status inconsistencies (customer: Sapiens, NX monorepo)

Fixes two client-side browserstack-cypress-cli defects surfaced by SDK-6463. The customer's reported dashboard count discrepancy is largely not a CLI bug (see RCA below); these two fixes address the genuine CLI defects: silently broken parallelization in NX monorepos, and accessibility-hook timeouts skipping tests.

RCA — the "inconsistency" is three layers

  • A. Test Observability rendering (grep-filtered tests shown as "Pending", timeout placeholders, new-dashboard counting) — faithful; owned by the TO/dashboard team, not the CLI.
  • B. Client-side test selection (@cypress/grep tags + browserstack.json exclude globs) — expected behavior.
  • C. Two real CLI defects — fixed here.

C.1 — TS cypress-config compile fails silently in NX monorepos → parallelization collapses

readCypressConfigUtil.convertTsConfig compiles the TS config to read it. In an NX/monorepo:

  • the extends temp tsconfig inherited base options (noEmit / emitDeclarationOnly / composite / noEmitOnError) that suppress or redirect the compiled JS, and
  • any tsc type error made tsc exit non-zero, which short-circuited the &&-chained tsc-alias, leaving path aliases (e.g. @org/lib) un-rewritten so the compiled config couldn't be require()d.

The read error was then silently swallowed (readCypressConfigFile catch) → cypressConfigFile = {}getNumberOfSpecFiles fell back to the default cypress/e2e/** glob → 0 specssetParallels forced parallels to browserCombinations.length. This is the customer's Parallels limit specified: 1 (despite parallels: 3) and the repeated Cypress config file not found at: …tmpBstackCompiledJs/… errors.

Fix (bin/helpers/readCypressConfigUtil.js):

  • Force emit-friendly overrides in the extends temp tsconfig: noEmit:false, emitDeclarationOnly:false, composite:false, declaration:false, declarationMap:false, noEmitOnError:false, incremental:false. These only affect the throwaway temp tsconfig used to read the config — not the user's real build.
  • Run tsc-alias unconditionally (& on Windows / ; on Unix instead of &&) so a tsc type error doesn't leave aliases un-rewritten. convertTsConfig already tolerates tsc errors by parsing the emitted-files output.

C.2 — accessibility afterEach scan/save timeout skips the rest of the spec

bin/accessibility-automation/cypress/index.js calls cy.wrap(performScan(win), {timeout:30000}) and cy.wrap(saveTestResults(win, …), {timeout:30000}) in the global afterEach with no rejection handling. When the in-page scanner doesn't echo A11Y_SCAN_FINISHED / A11Y_RESULTS_SAVED, the wrap times out, the afterEach hook fails, and Cypress skips all remaining tests in the spec — the ticket's "cy.wrap() timed out … Because this error occurred during a after each hook we are skipping all of the remaining tests" and "should have failed but got skipped".

Fix: add .catch to both wrap chains so a hung scan/save is logged, not cascaded into skipped tests.

Validation

C.1 — real BrowserStack infra (same project & config, only the CLI differs):

Unfixed CLI Fixed CLI
Cypress config file not found errors 2 0
Parallels limit specified (config has parallels: 3) 1 3
Build 7493f8339065f0570cd0867d7bec599487bb6dd9 bba6009df5e214058e1567f17ac268ea312675e0

C.1 — local NX tsconfig matrix: noEmit / emitDeclarationOnly / composite / noEmitOnError+type-error all fail to read the config before the fix and read OK after it.

C.2 — local simulation: drives the real plugin afterEach with a hung scanner; the new regression test fails without the fix and passes with it across hung-scan, hung-save, and happy-path scenarios.

Unit suite: 685 passing (was 678 → +7 new tests), 0 new failures (13 failures pre-exist on a clean tree and are unrelated).

Files

  • bin/helpers/readCypressConfigUtil.js — C.1 fix
  • bin/accessibility-automation/cypress/index.js — C.2 fix
  • test/unit/bin/helpers/readCypressConfigUtil.js — +3 C.1 regression tests
  • test/unit/bin/accessibility-automation/cypress/index.js — new, +4 C.2 regression tests

Notes / follow-ups

  • The dashboard count discrepancy (Layer A) should be routed to the Test Observability/dashboard team — it is not addressed here.
  • Latent bug spotted while investigating C.2: index.js:292 references an undefined includeTags (should be includeTagArray), reachable only when accessibility include/exclude tags are set. Not fixed here; worth a separate ticket.

🤖 Generated with Claude Code

Bhargavi-BS and others added 2 commits June 19, 2026 14:50
When the cypress config is TypeScript and lives in an NX/monorepo, the extends temp tsconfig inherited base options (noEmit / emitDeclarationOnly / composite / noEmitOnError) that suppress or redirect the compiled JS, and any tsc type-error short-circuited the '&&'-chained tsc-alias so path aliases were left un-rewritten. The compiled config then could not be found/required, the error was silently swallowed, and getNumberOfSpecFiles fell back to a default glob that found 0 specs -> setParallels collapsed parallels to 1.

Force emit-friendly overrides in the extends temp tsconfig and run tsc-alias unconditionally (& / ; instead of &&). Adds regression tests covering the emit-override and unconditional-alias behavior.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…K-6463)

A hung accessibility scan made the 30s cy.wrap() time out and fail the afterEach hook, which makes Cypress skip ALL remaining tests in the spec (they surface as 'skipped' instead of running). Add .catch handlers to both cy.wrap(..., {timeout:30000}) chains (performScan and saveTestResults) so a timeout is logged instead of cascading into skipped tests. Adds a regression test that loads the real plugin afterEach and asserts tolerance.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Bhargavi-BS Bhargavi-BS requested a review from a team as a code owner June 19, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant