Skip to content

Fix missing Browserbase SDK dependencies in generated templates - #103

Open
shrey150 wants to merge 2 commits into
devfrom
agent/add-missing-browserbase-sdk-deps
Open

Fix missing Browserbase SDK dependencies in generated templates#103
shrey150 wants to merge 2 commits into
devfrom
agent/add-missing-browserbase-sdk-deps

Conversation

@shrey150

@shrey150 shrey150 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add explicit TypeScript manifests for download-financial-statements and job-application
  • include @browserbasehq/sdk@^2.18.0 alongside their existing Stagehand, dotenv, and Zod dependencies
  • make both templates self-contained when cloned by create-browser-app or Browse instead of inheriting the basic scaffold's incomplete dependency set

Why

Both entrypoints import @browserbasehq/sdk, but neither template had its own package.json. Clean generated projects therefore installed the basic scaffold dependencies and failed immediately with ERR_MODULE_NOT_FOUND.

E2E Test Matrix

Command / flow Observed output Confidence / sufficiency
Clean pnpm install in each template Both installed @browserbasehq/sdk@2.18.0 and resolved SDK + Stagehand imports Proves generated dependency resolution is fixed
pnpm start — download financial statements PASS; downloaded all four FY2025 statements and produced a 14,332,637-byte ZIP Proves the clean generated project completes the real Browserbase downloads workflow
pnpm start — job application PASS; discovered nine synthetic jobs and completed all nine fixture submissions Proves the clean generated project completes the real Browserbase/Stagehand workflow

The job fixture run emitted existing non-fatal Stagehand socket-close warnings during cleanup; all nine task outcomes succeeded and the process exited zero.


Note

Low Risk
Dependency-only template manifests; no runtime, auth, or data-handling logic changes.

Overview
Adds dedicated package.json files for the download-financial-statements and job-application templates so generated projects install @browserbasehq/sdk (plus Stagehand, dotenv, and Zod) instead of falling back to the basic scaffold.

That fixes ERR_MODULE_NOT_FOUND when those templates are cloned via create-browser-app or Browse, since both entrypoints already import the SDK.

Reviewed by Cursor Bugbot for commit d3ca98d. Bugbot is set up for automated code reviews on this repo. Configure here.

@shrey150
shrey150 marked this pull request as ready for review August 21, 2026 19:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d3ca98d. Configure here.

Comment thread typescript/download-financial-statements/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant