fix(ci): point tests-complete needs at 'test' job so required check reports#51
Closed
nmccready wants to merge 1 commit into
Closed
fix(ci): point tests-complete needs at 'test' job so required check reports#51nmccready wants to merge 1 commit into
nmccready wants to merge 1 commit into
Conversation
nmccready
enabled auto-merge
June 24, 2026 16:58
auto-merge was automatically disabled
June 26, 2026 12:07
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
testsworkflow has been failing at validation (0s, no jobs created) since the reusable job was renamedtests→test. Thetests-completegate still referenced the old name:GitHub rejects the workflow ("depends on unknown job tests"), so no
testsstatus check is ever posted → PRs requiring thetestscheck are stuckBLOCKED(e.g. Dependabot PRs that never pass).Fix
Point the gate at the real job id
test.name: testsis unchanged, so the required check still reports astests— no branch-protection change needed.Found via org-wide audit of
tests.yml. Same fix applied to debug-fabulous and angular-simple-logger (the two repos with this mismatch).🤖 Generated with Claude Code