docs(release): bring the 2.6.2 notes up to the release..main delta - #631
Merged
Conversation
The 2.6.2 notes described the state of main as of #619. Five commits have landed since the branch point with release, and the notes covered only the lens ones. Adds a Fixes section for the two undocumented changes: - #622 (ADR 0030) nearby ranking. The BallTree behind the Nearby sort and the chart's nearby-DSO markers was indexed [ra, dec] against sklearn's haversine, which reads dimension 0 as latitude -- so separations were right only on a shared meridian and worse towards the poles. Plus the 200-object cap, the great-circle staleness trigger, the carousel counting the sorted list, and the serialisation fix that was blanking the remote web object-details view. - #623 observed-objects cache: one chunked, catalog-grouped query instead of a lookup per listing, and one shared ObservationsDatabase per process. Also corrects two figures the notes carried past #628, which measured the 12mm at 13.04mm: - the worked example still said a 12mm on an imx296 images 17.8 deg; it derives 16.38 deg, and the table in the same section already said so - Known Sharp Edges still claimed the 12mm's effective focal length was the nominal 12.0 with effective_focal_length_measured=False. It is measured. The zero point and f-number are what remain open on #612 And records what #628 means for self-heal -- at the nominal 12.0 a 12mm unit fitted 7.9% from derived, outside the 5% identification tolerance, so it could never promote -- plus the single-sample caveat, the solver's failed-solve log line, SortOrder.RA gaining an implementation while staying unreachable from the Quick Menu, and current test counts (1,305 unit+smoke, verified locally). No code changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2.6.2 release notes described main as of #619. Five commits have landed since the branch point with
release, and the notes covered only the lens ones (#624, #625, #628). This adds the other two and corrects two figures that #628 left stale.What was missing
#622 — nearby ranking (ADR 0030)
New
## Fixessection. TheBallTreebehind both the object list's Nearby sort and the chart's nearby-DSO marker layer was built and queried as[ra, dec]against sklearn's haversine metric, which reads dimension 0 as latitude. Separations were right only between objects on a shared meridian, and worse towards the poles.Also covered: the
NEAREST_LIST_CAP = 200window and what it costs the user, the great-circle staleness trigger replacing per-axis degrees (andMAX_TIME2 s → 10 s), the carousel counting_menu_items_sortedrather than the source, the cursor policy (top row follows the pointing, a scrolled cursor pins to its object), and theserialize_ui_statetruthiness fix that had been silently blanking the remote web interface's object-details view for every object opened from a Nearby list.#623 — observed-objects cache
One chunked, catalog-grouped query instead of a lookup per listing, and one shared
ObservationsDatabaseper UI process. Includes the measured numbers and why grouping by catalog code is load-bearing (SQLite will not drive a two-column index from a row-value list, so a single logged WDS listing dragged ~131k rows into every chunk).Corrections to existing text
Two figures survived #628's 13.04 mm measurement:
[8.0, 16.0].effective_focal_length_measured=False". It is measured, and the flag is true. What remains open on Calibrate the 12mm lens on-sky: effective focal length, SQM zero point, f-number #612 is the SQM zero point and the f-number, which the bullet and the follow-up entry now say.Also added
identify_lens_from_fitted_fovreturnedNoneon every frame and affected units would have solved on the wide assumed gate forever without ever promoting. At 13.04 mm that error is −0.07%.FOV est: 12.0°, max err: 4.0°and had been describing a window the solver had not used since Derive field of view from the optical train (sensor × lens) #609.SortOrder.RAgaining an implementation — the enum, the marking-menu branch and the "Sorting by RA" message all existed, butsort()had no branch, so selecting it announced a sort and left the list alone. Recorded as a sharp edge that it is still not offered in the Quick Menu.ObjectsDatabase.get_object_ids_by_listings(), theget_nr_of_menu_items()override, and ADR 0030 (including why it was renumbered off 0029).Verification
Every figure quoted was checked against the code in this worktree rather than carried over from the source PRs:
optics.OpticalTrain15.25 ± 3.59, imx46211.57 ± 2.73, hq[8.78, 11.88]) recomputed fromoptical_train_for_profile(profile, None)logconf_default.jsonroot-loggerERRORclaim read from the fileDocs only — no code changes.
🤖 Generated with Claude Code