Link commemorations to their full stories below the readings - #154
Merged
Conversation
…dings
Each saint/feast in the top-of-page commemorations list now links to its
corresponding story further down the page (in the section that follows
the scripture readings), when one exists. Day.saint_links pairs each
title with its DayCommemoration id (or None, for the story-less
antiochian.org-harvested entries) in parallel with self.saints, which
stays a plain string list since it's also consumed as such elsewhere
(ical.py, RSS feed description). Story articles get a matching
id="commemoration-{id}" anchor.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Day.saint_links(new, incalendarium/liturgics/day.py) pairs each title with itsDayCommemorationid (orNone) in parallel withself.saints--self.saintsitself is untouched, since it's also consumed as plain strings elsewhere (ical.py, RSS feed description)..commemorations li aCSS so the new links inherit the existing red color/no-underline styling instead of the browser's default blue/underlined link style (the readings page doesn't use the#contentwrapper that already had link styling elsewhere on the site).Test plan
🤖 Generated with Claude Code