Lower deployment target to iOS 16 with availability gating#5
Open
akaDuality wants to merge 1 commit into
Open
Conversation
Drop the @observable on StickerShaderUpdater (unobserved callback dispatcher) and gate the iOS 17 shader/accelerometer APIs behind @available(iOS 17, *) so the module imports into iOS 16 targets. stickerEffect() stays callable on iOS 16 as a no-op. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bpisano
requested changes
Jul 2, 2026
bpisano
left a comment
bpisano
left a comment
Owner
There was a problem hiding this comment.
Hi @akaDuality, thanks for the PR. The no-op behavior is too confusing. Callers get no compiler or runtime hint. I'd rather the constraint be explicit and enforced at build time. Making the modifier @available to iOS 17+ is a better solution to me.
| import SwiftUI | ||
| import CoreMotion | ||
|
|
||
| @available(iOS 17, *) |
Owner
There was a problem hiding this comment.
Is it required here? I don't see any iOS 17+ related API here
|
|
||
| import SwiftUI | ||
|
|
||
| @available(iOS 17, *) |
Owner
There was a problem hiding this comment.
This package is available on other platforms than iOS. You need to check for these platforms too
| platforms: [ | ||
| .iOS(.v17), | ||
| .iOS(.v16), | ||
| .macOS(.v14), |
Owner
There was a problem hiding this comment.
Is it possible to drop the macOS version to its iOS 16 equivalent too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the @observable on StickerShaderUpdater (unobserved callback dispatcher) and gate the iOS 17 shader/accelerometer APIs behind @available(iOS 17, *) so the module imports into iOS 16 targets. stickerEffect() stays callable on iOS 16 as a no-op.