Skip to content

fix(skills): green the skill-flow gate after skill-prune Phase 2#852

Open
boshu2 wants to merge 2 commits into
mainfrom
fix/skill-flow-prune-danglers
Open

fix(skills): green the skill-flow gate after skill-prune Phase 2#852
boshu2 wants to merge 2 commits into
mainfrom
fix/skill-flow-prune-danglers

Conversation

@boshu2

@boshu2 boshu2 commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Why

main is RED on the validate-skill-flow gate (wired into the contracts-sync CI job). The skill-prune Phase 2 (ag-if7p) deleted six skills — operating-loop-skill, brainstorm, design, ratchet, complexity, cass-memory — but left dangling references to them in surviving skills, producing 16 hard findings:

  • 6 × consumes-vocabularyagy-native, discovery (×2), eval-outcomes, refactor, rpi consume a deleted skill
  • 8 × metadata.dependenciesacfs, discovery (×2), eval-outcomes, perf, refactor, rpi, test depend on a deleted skill
  • 2 × orphanbeads-bv, cc-hooks are new skills with zero edges and no allowlist entry

What

  • Purge every reference to the six pruned skills across all three edge layers (consumes, metadata.dependencies, context_rel) in the 9 affected skills. Verified each survivor keeps its remaining edges — no new orphans introduced.
  • Allowlist the two genuine leaf skills: beads-bv (tracker-triage boundary to bv/br) and cc-hooks (Claude Code hooks runtime-config boundary).
  • Regenerate docs/contracts/context-map.md.

Verification

$ bash scripts/validate-skill-flow.sh
validate-skill-flow: 67 skill(s), 96 skill-to-skill edge(s)
  orphans: 10 (allowlisted standalone: 10)
OK: skill flow is connected and the consumes vocabulary is closed.   # exit 0, zero hard findings
  • validate-skill-flow.sh → exit 0 ✅
  • validate-context-map-drift.sh → exit 0 ✅
  • All 9 edited frontmatters parse as valid YAML ✅

Out of scope (separate follow-up)

The gate still emits two non-fatal WARNs left by the four-vendor-corpus (#803) and prune PRs: ~45 stale allowlist entries (dead refs to pruned skills) and ~60 unused EXTERNAL_INPUTS tokens. These don't block CI; cleaning them (and optionally escalating those WARNs to FAIL so they can't re-rot) is a deliberate follow-up, not bundled here to keep this fix-forward tightly scoped to greening the gate.

Bounded-context: BC1-Corpus
Evidence: OK: skill flow is connected and the consumes vocabulary is closed.


Generated by Claude Code

The skill-prune (ag-if7p) deleted six skills (operating-loop-skill,
brainstorm, design, ratchet, complexity, cass-memory) but left dangling
references in survivors, turning the validate-skill-flow gate RED on main
(16 hard findings: 6 consumes-vocabulary + 8 metadata.dependencies + 2
un-allowlisted orphans).

- Purge all references to the six pruned skills across consumes,
  metadata.dependencies, and context_rel in: acfs, agy-native, beads,
  discovery, eval-outcomes, perf, refactor, rpi, test. Each survivor keeps
  its other edges (no new orphans introduced).
- Allowlist two genuine new leaf skills (beads-bv tracker-triage boundary,
  cc-hooks runtime-config boundary) in scripts/skill-flow-standalone.txt.
- Regenerate docs/contracts/context-map.md.

Gate now passes: 67 skills, 96 edges, 10 orphans (all allowlisted), zero
hard findings. Out of scope (separate follow-up): pruning the ~45 stale
allowlist entries and ~60 unused EXTERNAL_INPUTS tokens (both non-fatal
WARNs left by the four-vendor-corpus and prune PRs).
Running scripts/regen-all.sh after removing the dangling pruned-skill
references regenerates registry.json and the skills-codex/*/.agentops-generated.json
twins for the 9 edited skills. Resolves the contracts-sync (registry drift)
and codex-parity CI failures. `regen-all.sh --check` is fully green.
@cursor

cursor Bot commented Jun 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_942bff22-3a15-4e0f-b09b-c321ac2aae15)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants