fix(skills): green the skill-flow gate after skill-prune Phase 2#852
Open
boshu2 wants to merge 2 commits into
Open
fix(skills): green the skill-flow gate after skill-prune Phase 2#852boshu2 wants to merge 2 commits into
boshu2 wants to merge 2 commits into
Conversation
The skill-prune (ag-if7p) deleted six skills (operating-loop-skill, brainstorm, design, ratchet, complexity, cass-memory) but left dangling references in survivors, turning the validate-skill-flow gate RED on main (16 hard findings: 6 consumes-vocabulary + 8 metadata.dependencies + 2 un-allowlisted orphans). - Purge all references to the six pruned skills across consumes, metadata.dependencies, and context_rel in: acfs, agy-native, beads, discovery, eval-outcomes, perf, refactor, rpi, test. Each survivor keeps its other edges (no new orphans introduced). - Allowlist two genuine new leaf skills (beads-bv tracker-triage boundary, cc-hooks runtime-config boundary) in scripts/skill-flow-standalone.txt. - Regenerate docs/contracts/context-map.md. Gate now passes: 67 skills, 96 edges, 10 orphans (all allowlisted), zero hard findings. Out of scope (separate follow-up): pruning the ~45 stale allowlist entries and ~60 unused EXTERNAL_INPUTS tokens (both non-fatal WARNs left by the four-vendor-corpus and prune PRs).
Running scripts/regen-all.sh after removing the dangling pruned-skill references regenerates registry.json and the skills-codex/*/.agentops-generated.json twins for the 9 edited skills. Resolves the contracts-sync (registry drift) and codex-parity CI failures. `regen-all.sh --check` is fully green.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_942bff22-3a15-4e0f-b09b-c321ac2aae15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis RED on thevalidate-skill-flowgate (wired into thecontracts-syncCI job). The skill-prune Phase 2 (ag-if7p) deleted six skills —operating-loop-skill,brainstorm,design,ratchet,complexity,cass-memory— but left dangling references to them in surviving skills, producing 16 hard findings:agy-native,discovery(×2),eval-outcomes,refactor,rpiconsume a deleted skillacfs,discovery(×2),eval-outcomes,perf,refactor,rpi,testdepend on a deleted skillbeads-bv,cc-hooksare new skills with zero edges and no allowlist entryWhat
consumes,metadata.dependencies,context_rel) in the 9 affected skills. Verified each survivor keeps its remaining edges — no new orphans introduced.beads-bv(tracker-triage boundary to bv/br) andcc-hooks(Claude Code hooks runtime-config boundary).docs/contracts/context-map.md.Verification
validate-skill-flow.sh→ exit 0 ✅validate-context-map-drift.sh→ exit 0 ✅Out of scope (separate follow-up)
The gate still emits two non-fatal WARNs left by the four-vendor-corpus (#803) and prune PRs: ~45 stale allowlist entries (dead refs to pruned skills) and ~60 unused
EXTERNAL_INPUTStokens. These don't block CI; cleaning them (and optionally escalating those WARNs to FAIL so they can't re-rot) is a deliberate follow-up, not bundled here to keep this fix-forward tightly scoped to greening the gate.Bounded-context: BC1-Corpus
Evidence: OK: skill flow is connected and the consumes vocabulary is closed.
Generated by Claude Code