libvirt: Set LC_ALL=C for virsh commands#286
Merged
Merged
Conversation
The virsh_command() helpers did not set a locale, so virsh output was localized in non-English environments. State comparisons like `state == "running"` would fail because virsh returned the translated string instead. Set LC_ALL=C on all three virsh_command() functions and update the integration tests that call virsh dominfo directly. Assisted-by: Claude Code (Claude Opus 4.6) Signed-off-by: Shion Tanaka <shtanaka@redhat.com>
tnk4on
changed the title
cgwalters
approved these changes
Jun 22, 2026
cgwalters
left a comment
cgwalters
left a comment
Collaborator
There was a problem hiding this comment.
Yeah, I did a Poc of using libvirt via API bindings, would still make sense to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
LC_ALL=Cto allvirsh_command()helper functions so that virsh output is always in English regardless of system locale. Without this, state comparisons likestate == "running"fail in non-English locales (e.g. Japanese returns "実行中").Integration tests that call
virsh dominfodirectly are also updated to useLC_ALL=C.Fixes: #285