Fix original M5Paper display refresh and SD mounting - #390
Merged
bmorcelli merged 2 commits intoAug 6, 2026
Conversation
Owner
|
Awesome!! I will test on Paper-S3 tomorrow and check if nothing broke on that side Thank you for helping!! |
bmorcelli
marked this pull request as ready for review
August 6, 2026 23:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
M5.Display, with explicit IT8951 completion waitsWhy
The first-generation M5Paper shares GPIO 12/13/14 between its IT8951 display and SD slot. Launcher previously constructed a separate
SPIClass, whose ESP32 default is HSPI. SD initialization then remapped those shared pins away from M5GFX's VSPI display immediately after the initial splash. The application continued running, but the panel remained on theLaunchersplash.Changing only the SD object to another VSPI owner allowed display updates but made SD mounting unreliable. Using Arduino's canonical
SPIinstance coordinates both libraries on the same hardware bus. Direct IT8951 presentation also avoids stale full-screen canvas pushes on this target.User impact
On original M5Paper hardware, Launcher now proceeds from the splash to the six-item main menu, accepts touch input, and mounts the inserted SD card instead of greying out
SD.Validation
pio run -e m5stack-paperbuild against currentmainSD,OTA,WUI,PMan,CFG,OFFSDCARD mounted successfullyand/config.confload