fix(app): block submitting an unchanged guide revision - #279
Open
douicoder wants to merge 2 commits into
Open
Conversation
Guard the guide and variant edit flows against submitting a revision that is byte-for-byte identical to the live revision. Compare the draft fields against the snapshot before persisting, and surface an error toast when nothing changed. Closes bluelearn-org#181 Signed-off-by: Doui <doui.gurvinder@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent submitting a guide (or variant) revision when nothing was changed. The edit flow shared by "Edit Guide" and "Edit Variant" now compares the draft fields against the live revision snapshot it was seeded from before persisting, and shows an error toast when the submission is a no-op.
isRevisionDraftUnchanged()pure helper inapp/src/lib/guideUtils.tspublish()in the edit route to block no-op submissionsapp/src/lib/__tests__/guideUtils.test.tsType of change
Verification
pnpm -r typecheckpassespnpm -r buildpassesCloses #181