Default query response time to P999 - #182
Draft
Areson wants to merge 1 commit into
Draft
Conversation
Apply the documented percentile default during collector preparation and reject invalid percentile metrics before collection. Add unit and MySQL 8.0 integration coverage. Co-authored-by: Codex <noreply@openai.com> Ai-assisted: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
query.response-timedocumentation promises P999 when no metrics are configured, but an empty list currently fails collector preparation. Invalid percentile names can also survive configuration and fail later during collection.What
p999during collector preparationpNformat and range before constructing queriesRisk Assessment
Low — the change is isolated to
query.response-timepreparation. Existing valid explicit metrics are unchanged, while invalid configurations fail earlier with an actionable error.References
Closes #132
Generated with Codex