graduate avatar collection canvas

[morgmart]

Category: improvement
User Impact: Everyone now chooses agent avatars from the full-screen, pannable collection canvas.
Problem: The collection canvas remained behind an experiment, leaving production users on a separate inline picker and requiring two avatar-selection paths to stay maintained.
Solution: Make the collection canvas the single avatar-picker experience across the agent builder and profile, then remove the experiment registration and legacy picker implementation. The canvas shows a neutral Berd loading state while its catalog loads. On agent profiles, it waits for persistence before closing and preserves failed selections for retry; in the builder, selections join the existing working buffer without prematurely saving unrelated edits.

File changes

scripts/design-system-audit.mjs
Removes a stale baseline exception after the retired inline profile editor styling was deleted.

src/features/agents/capabilities/tests/AgentBuilderCapability.test.tsx
Stops configuring the graduated experiment in capability setup.

src/features/agents/lib/getCachedAvatarMedia.ts
Moves cached avatar media lookup into a neutral shared utility used by the permanent canvas.

src/features/agents/ui/AgentAvatarSection.tsx
Removes the retired inline avatar customization surface.

src/features/agents/ui/AgentBuilderRail.tsx
Makes the collection canvas the sole avatar library path in compact and full-page builders.

src/features/agents/ui/AgentDetailPage.tsx
Opens the collection canvas directly from profile avatar customization and removes the legacy inline branch.

src/features/agents/ui/AvatarCollectionOverlay.tsx
Reads cached media through the neutral avatar utility, shows a neutral loading state, and supports async owners that preserve failed selections for retry.

src/features/agents/ui/AvatarLibraryPicker.tsx
Removes the retired inline avatar library implementation.

src/features/agents/ui/tests/AgentBuilderRail.test.tsx
Updates builder expectations for the always-on canvas, removes experiment-specific cases, and pins that avatar selection joins the existing working buffer without prematurely saving unrelated edits.

src/features/agents/ui/tests/AgentsView.entry.test.tsx
Covers permanent canvas opening from agent profiles, persistence, closure, telemetry, and failed-write behavior.

src/features/agents/ui/tests/AvatarCollectionOverlay.test.tsx
Covers loading feedback and retrying a failed selection without losing canvas context.

src/features/agents/ui/tests/AvatarLibraryPicker.test.tsx
Removes tests for the retired inline picker.

src/features/experiments/tests/ExperimentsSettings.test.tsx
Updates the supported experiment registry expectation.

src/features/experiments/experimentDefinitions.ts
Removes the avatar collection canvas experiment definition and identifier.

src/shared/i18n/tests/agentAvatarAffordanceLocaleParity.test.ts
Narrows locale parity coverage to the remaining profile avatar affordance copy.

src/shared/i18n/locales/en/agents.json
Removes English copy used only by the retired inline picker.

src/shared/i18n/locales/en/settings.json
Removes the graduated experiment’s English settings copy.

src/shared/i18n/locales/es/agents.json
Removes Spanish copy used only by the retired inline picker.

src/shared/i18n/locales/es/settings.json
Removes the graduated experiment’s Spanish settings copy.