fix(core): bound untrusted file reads and refuse irregular files - #77
Merged
Conversation
blackaxgit
commented
Aug 1, 2026
Owner
- Add clx_core::bounded_read: opens then fstats the handle (closing the stat-vs-open TOCTOU window), sets O_NONBLOCK on Unix so a writerless FIFO cannot hang the open itself, rejects non-regular files, caps by size, and still reads via take(cap) against post-fstat growth.
- Apply at all three untrusted-path reads: credentials.age (16 MiB), project/global instructions files (4 MiB), config-trust target (4 MiB).
- credentials.age treats non-regular and oversized as hard errors rather than an empty store, so a later set/delete can never re-encrypt an empty map over whatever is actually at that path.
- Add clx_core::bounded_read: opens then fstats the handle (closing the stat-vs-open TOCTOU window), sets O_NONBLOCK on Unix so a writerless FIFO cannot hang the open itself, rejects non-regular files, caps by size, and still reads via take(cap) against post-fstat growth. - Apply at all three untrusted-path reads: credentials.age (16 MiB), project/global instructions files (4 MiB), config-trust target (4 MiB). - credentials.age treats non-regular and oversized as hard errors rather than an empty store, so a later set/delete can never re-encrypt an empty map over whatever is actually at that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.