Retry preloader init when target config is unset - #323
Open
rohan87674 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some MT6768/MT6769 devices can successfully respond in BROM/preloader mode before
target_confighas been populated. In that case,DaHandler.connect()was aborting immediately even though a secondpreloader.init()call succeeded and recovered the configuration.This produced a false failure path that required a reconnect even though the device was still valid and usable.
What changed
The connection flow now retries
mtk.preloader.init()once whentarget_configis stillNonebefore treating the device as disconnected. The original fail-fast behavior is retained if initialization still does not populate the target configuration.This keeps the initialization logic aligned with the actual device state and avoids unnecessary disconnect/reconnect cycles for devices that recover immediately.
Validation
py -3 -m compileall -q mtkclient