Allow seeder to create a Free org with Secrets Manager - #8187
Allow seeder to create a Free org with Secrets Manager#8187nthompson-bitwarden wants to merge 1 commit into
Conversation
The seeder rejected any Free org that requested Secrets Manager with a 400, because PlanFeatures.EnableSecretsManager only allow-listed Teams/Enterprise plans. This diverges from production, where Bitwarden offers a free Secrets Manager tier. Add a PlanType.Free case that provisions the real free-tier base values (2 seats, 3 service accounts, per the FreePlan mock). Paid plans keep their existing smSeats-defaults-to-org.Seats behavior. Families and legacy plans still throw, matching production (they have no Secrets Manager tier). Update the stale OrganizationSeed doc comments and the unit tests: add a Free positive-path test and repoint the throw test at FamiliesAnnually.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the seeder change that adds a Code Review DetailsNo findings. Test coverage aligns with the change and CI (build plus |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8187 +/- ##
==========================================
- Coverage 63.87% 63.87% -0.01%
==========================================
Files 2352 2352
Lines 102209 102209
Branches 9227 9227
==========================================
- Hits 65287 65286 -1
- Misses 34698 34699 +1
Partials 2224 2224 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/QA-1864
📔 Objective
The seeder rejected any Free org that requested Secrets Manager with a 400, because PlanFeatures.EnableSecretsManager only allow-listed Teams/Enterprise plans. This diverges from production, where Bitwarden offers a free Secrets Manager tier.
Add a PlanType.Free case that provisions the real free-tier base values (2 seats, 3 service accounts, per the FreePlan mock). Paid plans keep their existing smSeats-defaults-to-org.Seats behavior. Families and legacy plans still throw, matching production (they have no Secrets Manager tier).
Update the stale OrganizationSeed doc comments and the unit tests: add a Free positive-path test and repoint the throw test at FamiliesAnnually.