Skip to content

Correct how the automatic Claude Code review is triggered - #8177

Open
Hinton wants to merge 1 commit into
mainfrom
docs/ai-review-gate
Open

Correct how the automatic Claude Code review is triggered#8177
Hinton wants to merge 1 commit into
mainfrom
docs/ai-review-gate

Conversation

@Hinton

@Hinton Hinton commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🎟️ Tracking

No ticket — drive-by fix spotted while resolving review feedback on the PAM stack (#8160–#8162)

📔 Objective

Fixes the instructions for how ai reviews behave. Stops claude from asking if you want the label applied.

@Hinton
Correct how the automatic Claude Code review is triggered
4111672 
CONTRIBUTING said the ai-review label is required and that "without the label,
the review doesn't fire." The gate in bitwarden/gh-actions/check-review-gate
reviews any non-draft PR automatically, once per PR; the label covers what that
safety net skips — drafts and repeat reviews.
@Hinton Hinton added the t:misc Change Type - ¯\_(ツ)_/¯ Prefer using other type labels label Aug 10, 2026
@Hinton
Hinton marked this pull request as ready for review August 10, 2026 09:30
@Hinton
Hinton requested a review from a team as a code owner August 10, 2026 09:30
@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR replaces one sentence in .claude/CONTRIBUTING.md describing how the automatic Claude Code review is triggered. The previous text claimed the review only fires when the ai-review label is applied; the updated text states that non-draft PRs are reviewed automatically and that the label is for drafts or re-reviews. This matches .github/workflows/review-code.yml, which triggers on opened, ready_for_review, reopened, and synchronize in addition to labeled — and is confirmed empirically by this PR, which received a review without the ai-review label. No other references to the label exist in the repo, so no further docs are left stale.

Code Review Details

No findings. Documentation-only change with no security, correctness, or compatibility impact.

Note: the "once per PR" and draft-gating behavior is implemented in the reusable bitwarden/gh-actions/.github/workflows/_review-code.yml, which was not accessible from this review environment. The wording is consistent with the trigger configuration in this repo.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.35%. Comparing base (42d286e) to head (4111672).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8177   +/-   ##
=======================================
  Coverage   63.35%   63.35%           
=======================================
  Files        2337     2337           
  Lines      101412   101412           
  Branches     9159     9159           
=======================================
  Hits        64248    64248           
  Misses      34951    34951           
  Partials     2213     2213

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hinton Hinton added t:llm Change Type - LLM related change (e.g. CLAUDE.md files) and removed t:misc Change Type - ¯\_(ツ)_/¯ Prefer using other type labels labels Aug 10, 2026
SaintPatrck
SaintPatrck reviewed Aug 10, 2026
View reviewed changes
Comment thread .claude/CONTRIBUTING.md

- Run a local Bitwarden Claude Code review with `/bitwarden-code-review:code-review-local` — it writes findings to files so you can fix them before pushing, without posting anything to GitHub.
- When you raise the PR, apply the `ai-review` label. Our reusable GitHub workflow watches for it and runs a Claude Code review automatically; without the label, the review doesn't fire.
- A non-draft PR gets a Claude Code review automatically once per PR, no label needed. Apply `ai-review` to review a draft or re-review after one has posted.

@SaintPatrck SaintPatrck Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 This is true for all repos. What do you think about adjusting creating-pull-request to account for this so it doesn't need to be added in multiple repos? Chances are creating-pull-request is why it's asking for a label in the first place, unless there's something else in this repo or your local environment driving the prompt that I'm not seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaintPatrck SaintPatrck SaintPatrck left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hinton @SaintPatrck