feat(token-refresh): POC - Copy email to salt when exchanging refresh token for access token - #8127
Draft
Patrick-Pimentel-Bitwarden wants to merge 2 commits into
Draft
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+292
to
+297
| catch (Exception e) | ||
| { | ||
| // Log and swallow exceptions from this non-critical backfill, as we don't want to fail | ||
| // refreshes due to issues writing the master password salt. | ||
| _logger.LogWarning(e, "Failed to update master password salt for user {UserId}.", userIdString); | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8127 +/- ##
==========================================
+ Coverage 62.87% 62.88% +0.01%
==========================================
Files 2310 2311 +1
Lines 100316 100353 +37
Branches 9028 9034 +6
==========================================
+ Hits 63074 63111 +37
+ Misses 35058 35057 -1
- Partials 2184 2185 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
📸 Screenshots