perf: import pkc-js via the slim ./client entry#113
Draft
Rinse12 wants to merge 1 commit into
Draft
Conversation
BaseCommand._connectToPkcRpc() is RPC-only (it always passes pkcRpcClientsOptions), so it can use @pkcprotocol/pkc-js/client — a slim export that defers the local-node/signer/kubo/undici graphs behind lazy imports. On a slow host this cuts the pkc-js import from ~1.97s to ~1.22s. Blocked on @pkcprotocol/pkc-js releasing the ./client export (pkcprotocol/pkc-js#178 / #179); bump the pkc-js dependency to that release before merging.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BaseCommand._connectToPkcRpc()is RPC-only — it always constructsPKC({ pkcRpcClientsOptions: [pkcRpcUrl] })and never starts a local node. Switch its import from@pkcprotocol/pkc-jsto the new slim@pkcprotocol/pkc-js/clientexport, which defers thelocal-node / signer / kubo-rpc-client / undici / thumbnail graphs behind lazy imports.
One-line change (
src/cli/base-command.ts).Impact
On a slow production host the pkc-js import drops from ~1.97s to ~1.22s;
community list -qend toend from ~3.34s to ~2.6s.
The
./clientexport does not exist in the currently published@pkcprotocol/pkc-js(0.0.62). ThisPR must not merge until pkc-js ships it — see pkcprotocol/pkc-js#178 (pkcprotocol/pkc-js#179) — and
the
@pkcprotocol/pkc-jsdependency here is bumped to that release. Opening as a draft to track.