Portfolio: Fix - Prevent worklet cached Hermes value race#2231
Open
msalcala11 wants to merge 1 commit into
Open
Portfolio: Fix - Prevent worklet cached Hermes value race#2231msalcala11 wants to merge 1 commit into
msalcala11 wants to merge 1 commit into
Conversation
msalcala11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The react-native-worklets package let multiple Worklet threads replace the same cached Hermes value at once, causing one thread to destroy memory another thread was still using, which led to a crash. This patch locks cache ownership and makes other runtimes create their own temporary values instead.