Fix CPX UART flow-control handling#600
Open
ataffanel wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CPX UART flow-control handling in
UARTTransport.The previous implementation used one
Lockboth to serialize outgoing writes and to represent incoming UART CTS (0xFF 0x00). This could crash with:when duplicate or unsolicited CTS frames arrived while no write was pending.
This PR replaces that lock-as-CTS mechanism with explicit flow-control state:
threading.Eventto track peer CTS0xFF 0x00frames as harmless CTS eventsFixes #599.
Testing
python -m unittest test.cpx.test_uart_transportpython -m unittest discover test