scripts: validate the first Comments-URI entry - #2233
Open
grandpig wants to merge 1 commit into
Open
Conversation
Signed-off-by: grandpig <grandpig@outlook.com>
murchandamus
reviewed
Aug 5, 2026
| } | ||
| } elsif ($field eq 'Comments-URI') { | ||
| if ($found{'Comments-URI'}) { | ||
| if (not $found{'Comments-URI'}) { |
Member
There was a problem hiding this comment.
This change makes sense to me. I see that I introduced this mistake in #1820. Thanks for catching that.
It’s not clear to me why we should be adding the second script to our build actions. It seems to be a proof that the bugfix change is correct, but if that’s the case adding it to the build actions going forth seems unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Comments-URIvalidation condition was reversed when the field was made optional.$found{'Comments-URI'}is incremented only after the current header line has been processed. As a result, the existing condition skipped validation for the first entry and applied it to continuation entries instead.This allowed a nonstandard first
Comments-URIto pass, while rejecting a valid external discussion URI following the standard Comments wiki URI.Restore the original condition so that only the first entry must match:
Additional continuation entries remain unrestricted.