build: pin esp toolchain to 1.93.0.0 to avoid LLVM 21 miscompile - #17
Open
rkuester wants to merge 2 commits into
Open
build: pin esp toolchain to 1.93.0.0 to avoid LLVM 21 miscompile#17rkuester wants to merge 2 commits into
rkuester wants to merge 2 commits into
Conversation
esp toolchains 1.94.x and 1.95.x ship LLVM 21, which fails to compile release builds for the Xtensa target. Version 1.93.0.0, the last release on LLVM 20, builds correctly. Pin the espup install step to 1.93.0.0 and note the reason.
esp toolchains 1.94.x and 1.95.x ship LLVM 21, which fails to compile release builds for the Xtensa target with the error `rustc-LLVM ERROR: Cannot select`. Version 1.93.0.0, the last release on LLVM 20, builds correctly. Check the LLVM version in the build script and stop the build with instructions to install 1.93.0.0 when it is 21 or newer, catching an accidental toolchain update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esp toolchains 1.94.x and 1.95.x ship LLVM 21, which fails to compile
release builds for the Xtensa target.
cargo build --releaseaborts withrustc-LLVM ERROR: Cannot select ... XtensaISD::PCREL_WRAPPER. Version1.93.0.0, the last release on LLVM 20, builds correctly. See #16 for the
full writeup and upstream references (esp-rs/rust#277, candidate fix
espressif/llvm-project@39a5993).
Two commits, to be reverted once a fixed LLVM 21 toolchain is confirmed:
docs(readme): pin the espup install step to 1.93.0.0 and note thereason.
build: check the bundled LLVM version in the build script and stop thebuild with install instructions when it is 21 or newer, catching an
accidental toolchain update.